[engine] Network settings (targeting wip-tenants) front#6102
THIS BRANCH IS TARGETING wip-tenants
Ticket(s) / Related Merge Requests
- Issue card: front#6102 (closed)
- Front MR: front!2458 (merged)
Summary of Changes
Adds a network settings panel for tenant network admin users to configure various settings of their network.
Testing Considerations
Important points
- You must test on https://c81e728d9d4c2f636f067f89cc14862c.bens-networks.oke.minds.io/newsfeed/subscriptions/latest - NOT the sandbox linked in the MR.
- You will need to be logged in as the
@admin
account for this tenant network with VPN - ping me for the details for the account. - You will need a secondary account - creation doesn't work on this sandbox due to the changes it is branched off. I've set up
@testacc
and can share the password to that too. - Logging in will likely take multiple submissions - when it hangs, refresh to be logged in (unrelated to this change)
- Various deviations from design have been approved by @chints98 and @mwrobs.
- You are highly likely to find many issues when testing multi-tenant networks - this bases off a huge change for them - please do report any bugs but run them by us first as they may NOT be a failure for this card.
- Image resizing and validation will be handled in another issue card.
- The configs for this are such that the domain E2E tests against is NOT the actual domain we want to test against. E2E will very likely red light.
- Copy link container is commented out at request of design and Mark as it is not ready.
- Domain section was asked to be removed from general - this is removed from later design iterations.
Checklist
-
Can change network name, changes persist and site title and section header are updated. -
Can change theme, changes persist and the theme is updated appropriately. (note the user level dark mode light mode selector is being removed in another change). Note you CAN mess up the palette by picking a color that does not work with your chosen theme. This is intentional. -
Favicon change uploads favicon, and the changes persist -
When changing square image the image it updated in the topbar. We are aware if it is NOT perfectly square it may not sit right in the topbar. We have another task to improve validation around this. -
You can upload a horizontal logo but it isn't used anywhere. -
Check mobile viewport and mid-width viewport for topbar / sidenav logo changes. -
Meta og:author
&og:title
are set to the site name. -
Validation on site name should work to prevent submission of under 3 and over 50 characters. -
Logo should be visible logged out. -
Sidenav icon for admin panel should not appear when not under VPN. -
Sidenav icon for admin panel should not appear when not an admin user. -
Sidenav icon for admin panel should not appear when not logged in but under a VPN (guest-mode). -
Login and register modals should show logo and correct title. -
Search bar should just say "Search" not "Search Minds" -
Navigating direct to the route for the panel when not an admin user under VPN should redirect you away.
Deployment Considerations
We should discuss merge strategy - my first thought is that this should go into wip-tenants
as that needs significant QA pre-release.
Regression Scope
Significant - allows dynamic changing of the logged-in site theme.
Platform Affected (web, mobile, etc)
Web / mobile web.
Developer Testing Completed
Manual, unit.
Screenshots / Screen Recording
Setting changing and persistence
simplescreenrecorder-2023-10-18_11.19.56
Mobile web topbar & sidebar logo changes
Note that I have intentionally shown what happens when you upload a wide image too - this is expected.
simplescreenrecorder-2023-10-18_11.33.05
og:author / author / title
Validation on site name should work to prevent submission of under 3 characters and over 50.
Logo visible logged-out
Register modal
Login modal
Sidenav icon for admin panel should not appear when not under VPN.
Sidenav icon for admin panel should not appear when not an admin user.
Sidenav icon for admin panel should not appear when not logged in but under a VPN (guest-mode).
Search bar
Navigating away when not authorized to view admin panel
simplescreenrecorder-2023-10-18_11.50.50
Does this impact
-
Localization -
Dark/light mode -
Guest mode
Definition of Done Checklist
-
The Acceptance Criteria has been met -
Code is tested: Testing includes unit/spec, E2E/automated and manual testing -
Merge requests description has been filled out
Edited by Ben