Skip to content

Fix YouTube import edit spam minds#4359

Ben requested to merge fix/youtube-import-m4359 into master

Ticket(s) / Related Merge Requests

minds#4359 (closed)

Summary of Changes

Fixes issue with YouTube importer where editing a video will cause a repost. This change means that videos will only be cross-posted if when the event is received, the difference in the publish and update times are LESS than a configurable variable (defaulted to 1 day).

I've left this number as configurable because 1 day may be an extreme amount of time. I made the default this large because due to limitations on my account, I cannot ascertain whether update times are set after processing and publish times before by testing with a large video. I put 1 day as default to cover the scenario where this is the case, as this gives a day for the video to transcode.

Testing Considerations

First, connect YT sync at https://fix-youtube-import-m4359.oke.minds.io/settings/other/youtube-migration - if you're already connected make sure to disconnect and reconnect. For entering your channel in your description on YT, use your channel on this sandbox e.g. https://fix-youtube-import-m4359.oke.minds.io/nemofin

  • Upload a new YT video, after waiting a minute it should appear on your channel.
  • Edit a video that is under 1 day old - it should be reposted to your channel.
  • If one exists, edit a video title you already have that is older than a day - wait a min - it should not be posted to your account.

Deployment Considerations

For @tanyatech

  • Can be promoted to prod as normal - the below is fine to happen post-production push.

For @markharding:

  • Remove cloudflare block.
  • Try running renewSubscriptions in CLI.
  • We can keep the runner scaled down. It's only used for transcoding, which isn't something we do anymore.

Regression Scope

Youtube importer.

Platform Affected (web, mobile, etc)

Web.

Developer Testing Completed

Manual.

Screenshots / Screen Recording

Edits

simplescreenrecorder-2023-10-06_15.28.30

New Video

simplescreenrecorder-2023-10-06_15.30.33

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Ben

Merge request reports