Skip to content

Fix ACL issue that can cause a rare failed load from trends endpoint #2615

Ben requested to merge fix/trending-feed-2615 into master

Ticket(s) / Related Merge Requests

#2615 (closed)

Summary of Changes

Fixes a rarely occurring issue where a null entity is passed to the ACL causing an uncaught exception to cascade out and prevent feed loading.

Testing Considerations

Not sure that this is entirely testable on a sandbox. In staging check that /discovery/plus/overview loads for you. (trends endpoint).

Deployment Considerations

Standard deployment.

Regression Scope

Trends endpoint (Plus feed). Minimal - just adds a check that the entity exists.

Platform Affected (web, mobile etc)

Engine.

Developer Testing Completed

Manual.

Screenshots / Screen Recording

Not a lot to screenshot for this that would be meaningful. Here it is working locally (ignoring a local issue where the thumbnail is broken).

image

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out

Merge request reports