Skip to content

Fix comment videos front#6069

Ben requested to merge fix/comment-images-f6069 into master

Ticket(s) / Related Merge Requests

front#6069

Summary of Changes

Fix for videos not playing in the comments. Comment videos have the access ID of the USER who owns the comment - this causes a failure in the adjusted ACL hook, which does not run an ACL check on the user.

Testing Considerations

Videos do not work correctly in sandboxes, thus actual verification of seeing a video will have to be done on staging.

Sandbox
Additional staging testing

Make a comment with a video.

  • You can view it from the owner.
  • You can view it from a logged-out state.
  • You can view it from another user.

Deployment Considerations

Standard deployment.

Regression Scope

Comment videos.

Platform Affected (web, mobile, etc)

Engine.

Developer Testing Completed

Manual.

Screenshots / Screen Recording

simplescreenrecorder-2023-08-16_13.00.16

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Ben

Merge request reports

Loading