Skip to content

Run acl against remind creation. Clean up some ACL code #2595

Mark Harding requested to merge fix/2595-remind-acl into master

Ticket(s) / Related Merge Requests

#2595

Summary of Changes

Cleans up ACL code and prevents a user from reminding, or quoting, an unlisted post.

Testing Considerations

See scenario in https://gitlab.com/minds/engine/-/issues/2595

Will require extensive testing in staging

Deployment Considerations

Regression Scope

This makes some changes to the ACL that might impact access to resources. The changes here lock down the ACL further, so the risk is with entities no longer being accessible that previously where, rather than the other way around.

Platform Affected (web, mobile, etc)

API

Developer Testing Completed

@markharding locally, waiting for sandbox

Screenshots / Screen Recording

acl-fix

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Mark Harding

Merge request reports