[engine] Fix group moderation minds#3928
Ticket(s) / Related Merge Requests
- Issue card: minds#3928
- Front MR: front!2265 (merged)
Summary of Changes
Fixes issues with group moderation and fixes another issue with search indexing on edit where in-memory cached entities were being returned in some scenarios, reading to inaccurate writes to ES.
Testing Considerations
Given two users Moderator and Member
- With
Moderator- Make a group, make it moderated - With
Member- Make a post in the group. - With `Moderator - Approve the post.
- With both users - Check the post is visible for both users.
Deployment Considerations
Standard deployment - make sure it goes out to runners.
Regression Scope
- Groups, around moderation - previously it was not working at all but any issues should be reported and we can decide how to handle on the fly.
- Be sure to test different entity types (one that stands out as an important area is multi-image due to the way we use
container_guid's. - Also given changes to the search index dispatcher, test create and edit ops around the site.
Platform Affected (web, mobile, etc)
Web
Developer Testing Completed
Manual, unit (phpspec).
Screenshots / Screen Recording
simplescreenrecorder-2023-05-03_18.16.15
Does this impact
-
Localization -
Dark/light mode -
Guest mode
Definition of Done Checklist
-
The Acceptance Criteria has been met -
Code is tested: Testing includes unit/spec, E2E/automated and manual testing -
Merge requests description has been filled out
Edited by Ben