Skip to content

Fix video to activity property propagation minds#3779

Ben requested to merge fix/vertical-video-display-2-m3779 into master

Ticket(s) / Related Merge Requests

minds#3779 (closed)

Summary of Changes

Since the multi-image changes were introduced, we have stopped storing the old activity:entitylink:<guid> rows in the entities_by_time table that were allowing us to check which activity belonged to a video - in favor of this, we switched to storing the activity GUID as the container GUID of the video. When we did this, it appears property propagation broke unidirectionally, from video to activity.

This meant that when the Cloudflare hook is called on transcode completion, it was unable to find a linked activity for the video, thus unable to propagate the dimensions to the linked activity - as a result the video was falling back to a default widescreen player.

Testing Considerations

mixkit-tree-with-yellow-flowers-1173-medium

  1. Post a tall video, such as the one linked above.
  2. Note that the player is widescreen (Cloudflare webhooks aren't set up so this is to be expected)
  3. Get the video GUID for the video (look in network logs on the SEP (api/v2/entities endpoint), in the entities custom_data
  4. run this in the pod - specify the correct guid, and the width and height you want
source /vault/secrets/env && php cli.php Cloudflare onWebhookOverride --videoGuid=1495772924555038727 --height=500 --width=300 --state=ready
  1. You should see on refresh the activity height and width changes to what you specified in the command.

Deployment Considerations

Standard deployment

Regression Scope

Cloudflare webhook and property propagation from entities to activities.

Platform Affected (web, mobile, etc)

Web.

Developer Testing Completed

Unit (phpspec) and unit.

Screenshots / Screen Recording

simplescreenrecorder-2023-04-20_14.20.06

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out

Merge request reports