Skip to content

Allow rich embed posts without content #2554

Ben requested to merge fix/rich-embed-no-content-2554 into master

Ticket(s) / Related Merge Requests

#2554 (closed)

Summary of Changes

Testing Considerations

Metascraper is DOWN on sandbox so you will have to use a URL that we already have cached to test - I'm using http://thesundaybe.st/?utm_source=testing&utm_medium=somethingsomething&utm_id=minds-test

  1. Enter that link into composer
  2. Wait for preview to generate
  3. Remove text
  4. Post
  5. You should see:

image

This IS how it worked previously - I have checked by reverting my branch.

We should test combinations of posts and text work

Deployment Considerations

Standard deployment

Regression Scope

Need to check activity posting of many different permutations of activity types / rich embeds and text assosciated.

Platform Affected (web, mobile, etc)

Engine change

Developer Testing Completed

Manual, unit (phpspec)

Screenshots / Screen Recording

simplescreenrecorder-2023-03-30_12.13.05

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Ben

Merge request reports