Prevent entities from blocked users from showing in boost minds#3747
Ticket(s) / Related Merge Requests
Summary of Changes
We already indirectly fixed boosts from blocked users being shown when we fixed boosts from banned channels trying to show - by adding ACL checks - what we DIDN'T fix was that if you block a user (USER_A), and someone else boosts their post (USER_B), you would still see USER_A's boosted post, because the boost would be owned by USER_B who you don't have blocked.
This change makes it so that you don't see Boost from users you have blocked AND you do not see boosted entities from users that you don't have blocked, even if you don't have the booster blocked.
Testing Considerations
Note the AC changes significantly - we could not move from Vitess - these changes have been approved by Mark. There is no change to block behavior beyond that boosted entities from blocked users won't show.
If you're quick enough, this post may still be at the top of the boost feed
https://fix-blocked-boosts-m3747.oke.minds.io/newsfeed/1475268061375238152
If it is, that boost is owned by testacc4, the rest are owned by the E2E test user.
Thus if you block testacc4 and check the boost feed, that post should vanish.
If you block playwright_tests_user then all of the boosts should disapear.
If you don't see that boost
Find the boost at the top of the boost feed and change the owner_guid in Vitess to another user guid, then repeat the above.
Deployment Considerations
Standard deployment.
Regression Scope
ACL / boost feed
Platform Affected (web, mobile, etc)
Web
Developer Testing Completed
Manual, phpspec
Screenshots / Screen Recording
simplescreenrecorder-2023-02-24_10.29.32
Does this impact
-
Localization -
Dark/light mode -
Guest mode
Definition of Done Checklist
-
The Acceptance Criteria has been met -
Code is tested: Testing includes unit/spec, E2E/automated and manual testing -
Merge requests description has been filled out