Skip to content

Exclude Boosts from banned users minds#3746

Ben requested to merge fix/acl-boosts-m3746 into master

Ticket(s) / Related Merge Requests

minds#3746

Summary of Changes

Adds ACL checks to Boost repository such that banned users will be excluded from results.

Testing Considerations

  • Make a boost with a user.
  • Run the boost rankings job from either the pod for this MR !1251 (merged) or one up to date with that change so that it appears.
# may want to double check this is needed with Mark - runner may be deployed by the time we do QA
source /vault/secrets/env && php cli.php Boost rank --sleep=10
  • Look in the boost feed to see your user or look for it in feeds.
  • Ban the user.
  • See if you can see the boost.
Quick test path

Else - look in boost feed, if you see the user BenHayward - you're welcome to ban it from the admin channel and check after waiting a short time and some hard refreshes it disapears (may take a few refreshes because of local caching):

Deployment Considerations

Standard deployment.

Regression Scope

Boost display.

Platform Affected (web, mobile, etc)

Engine.

Developer Testing Completed

Manual / Unit.

Screenshots / Screen Recording

See https://gitlab.com/minds/minds/-/issues/3746#note_1278530729

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Ben

Merge request reports