(fix): gif images not playing correctly in feeds
Ticket(s) / Related Merge Requests
Summary of Changes
If image/gif
is present in the Content-Type
header, then we skip stripping EXIF data. We could also try to rebuild the image w/ all the frames by using getImagesBlob
rather than getImageBlob
, but probably overkill since Gifs do not support EXIF data.
https://superuser.com/questions/556315/gif-image-exif-tags
https://www.php.net/manual/en/imagick.getimageblob.php https://www.php.net/manual/en/imagick.getimagesblob.php
Testing Considerations
Test uploading a Gif
Deployment Considerations
May need to invalidate cache for images
Regression Scope
Images
Platform Affected (web, mobile, etc)
Web
Developer Testing Completed
Tested uploading Gifs locally and in Sandbox
Screenshots / Screen Recording
Does this impact
-
Localization -
Dark/light mode -
Guest mode
Definition of Done Checklist
-
The Acceptance Criteria has been met -
Code is tested: Testing includes unit/spec, E2E/automated and manual testing -
Merge requests description has been filled out
Edited by Zack Wynne