Skip to content

[engine] Enable deletion of child comments by direct parents #2401

Ben requested to merge feat/child-comment-deletion-2401 into master

Ticket(s) / Related Merge Requests

Summary of Changes

Allow commenters to delete DIRECT child comments of their comments (NOT grandchildren).

Testing Considerations

Note - it was decided that for now, it is acceptable that grandchild comments CANNOT be deleted, and that deleting a comment with children WILL orphan the children (as it happens already).

Open 3 browser sessions on different users

Create a nested comment tree

Ensure you can delete the comments appropriately.

Ensure the post owner can delete them still.

Ensure comment owners can delete their own comments.

Deployment Considerations

Standard deployment.

Regression Scope

Comment deletion.

Platform Affected (web, mobile, etc)

Web

Developer Testing Completed

PHPSpec / Karma/Jasmine / Manual

Screenshots / Screen Recording

Post Owner

simplescreenrecorder-2022-11-10_10.49.08

Orphaning and self deletion

simplescreenrecorder-2022-11-10_10.37.08

All menu options and child deletion

simplescreenrecorder-2022-11-10_10.34.54

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manXal testing
  • Merge requests description has been filled out
Edited by Ben

Merge request reports