Skip to content

(fix): adding condition to avoid ES queries on #e or #p filter #2357

Zack Wynne requested to merge fix/nostr-notifs-2357 into master

Ticket(s) / Related Merge Requests

Issue: #2357 (closed)

Summary of Changes

This MR fixes an issue where Minds posts are returned when an #e or #p filter is being used. Since we don't support replies/references yet for Minds posts, this just skips the ES query if these are present.

Testing Considerations

You can test by sending this event:

["REQ","main-channel",{"kinds":[1,4],"#p":["2011d5b57d79bd8f24a86dc790ef64595dd54bb58762d737e33352bf60f5f682"]}]

Deployment Considerations

No specific deployment considerations.

Regression Scope

This should affect the Nostr endpoints only.

Platform Affected (web, mobile, etc)

Web

Developer Testing Completed

Tested that the above query returns irrelevant events prior to this change, and that these are no longer returned when the query is in place.

Screenshots / Screen Recording

image

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Zack Wynne

Merge request reports