Skip to content

Fix 500 thrown when no license is passed to the engine on image edit #2372

Ben requested to merge fix/nullable-license-500s-2372 into master

Ticket(s) / Related Merge Requests

Summary of Changes

#2372 (closed)

Testing Considerations

Probably more effort to test than it is to merge given the non-existent regression scope - since you asked nicely though

Options

  • Point mobile at the sandbox and check edits as per the issue card
  • Make edits to your front-end to NOT pass a license through on edit, and serve it using the sandbox engine host

image

Deployment Considerations

N/A

Regression Scope

Pretty much non-existant. In the worst case, there's another downstream bug that hasn't been caught by my testing, causing the same symptoms.

Platform Affected (web, mobile, etc)

Web / Mob

Developer Testing Completed

Manual

Screenshots / Screen Recording

Old behavior (with prod engine host)

image

Pointed at this sandbox

simplescreenrecorder-2022-08-02_14.18.22

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Ben

Merge request reports

Loading