Skip to content

Fix experiment manager instantiation for email confirmation front#5661

Ben requested to merge fix/dual-conf-email-f5661 into master

Ticket(s) / Related Merge Requests

front#5661 (closed)

Summary of Changes

It appears that the Experiment Manager was not correctly instantiated at the time we call it, so the experiment for email codes was not found when registering, and therefore was always appearing as if it was OFF. This meant when the front-end said the code experiment is on, it would correctly send a code by request on the front-end, but an old verification email would still be sent on the backend as if it was off.

This fix addresses the problem by preventing the DI from returning a singleton instance, where-in features may not be initialized.

The advantage of this approach is that if we don't do this - we will trip over this again in the future.

Testing Considerations

Spin up many accounts - there are two different experiment buckets to test

  1. Email code - an email code should be sent WITHOUT the clickable link verification.
  2. Clickable link verification - a clickable link email should be sent WITHOUT a code verification.

Deployment Considerations

Standard deployment.

Regression Scope

Effects registration confirmation emails

Platform Affected (web, mobile, etc)

Engine

Developer Testing Completed

N/A

Screenshots / Screen Recording

These emails arrived correctly depending which bucket I was in:

image

image

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Ben

Merge request reports