Make wire GUID publicly encapsulated for ACL access. front#5563
Ticket(s) / Related Merge Requests
Summary of Changes
Make GUID publicly accessible so that the ACL can grab it when writing an error. The alternative to this would be to change the ACL to use getGuid() - given the scope of the ACL this has a much wider regression scope and I think conceding a change to encapsulation in the Wire class is the most sensible path forward.
Testing Considerations
This is happening when an account is deactivated after sending a wire so:
- Make an account.
- Give it offchain tokens.
- Enter this engine pod and start notif stream
php /var/www/Minds/engine/cli.php EventStreams --subscription=Core\\Notifications\\NotificationsEventStreamsSubscription- Send a wire to another channel.
- Deactivate the account.
- Login as the wire recipient.
- Notifs should load fine (not showing the notif).
Deployment Considerations
Standard deployment.
Regression Scope
Minor changes to make encapsulation in the wire class - would not feasibly break anything.
Platform Affected (web, mobile, etc)
Engine
Developer Testing Completed
Manual
Screenshots / Screen Recording
Does this impact
-
Localization -
Dark/light mode -
Guest mode
Definition of Done Checklist
-
The Acceptance Criteria has been met -
Code is tested: Testing includes unit/spec, E2E/automated and manual testing -
Merge requests description has been filled out
Edited by Ben