Skip to content

fix phpstan errors - #2348

Mark Harding requested to merge fix/phpstan into master

Ticket(s) / Related Merge Requests

#2348 (closed)

Summary of Changes

Excludes failing files. Pulsar was causing parallel jobs to stall. Resolves newly found 'iterable' errors

Testing Considerations

Green light on static-analysis job in pipeline

Deployment Considerations

None

Regression Scope

phpstan was complaining about 'empty()' errors. There may be scope for regression here but I've only excluded in cases where we wouldn't be checking for null or empty string anyway.

Platform Affected (web, mobile, etc)

Backend

Developer Testing Completed

👍 @markeharding

Screenshots / Screen Recording

N/A

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out

Merge request reports