Skip to content

(fix): Moving Etherscan requests from HTTP to HTTPS front#5567

Zack Wynne requested to merge fix/move-etherscan-to-https-frontend-5567 into master

Ticket(s) / Related Merge Requests

Issue: front#5567 (closed)

Summary of Changes

This MR moves the plaintext HTTP requests for Etherscan to HTTPS, so that these requests can confirm to our network policies.

This should address this error:

php cli.php: [EXCEPTION:Exception] Failed to connect to api.etherscan.io port 80 after 257567 ms: Operation timed out

Testing Considerations

This should affect the rewards runner.

Deployment Considerations

We can test that connections to the above hostname are working within the pod.

Regression Scope

This should affect the rewards runner.

Platform Affected (web, mobile, etc)

Web

Developer Testing Completed

Tested requesting Etherscan on HTTPS to ensure that this protocol is supported.

Screenshots / Screen Recording

N/A

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out

Merge request reports