Improve support for selected-by-default option on Property

Laurent Savaëterequested to merge
LaurentS/sdk:add-selected-by-default-props into main

This PR is mostly driven by https://github.com/MeltanoLabs/tap-github/issues/34 for which I proposed to use selected-by-default: false in the catalog. The SDK does not seem to provide a way to actually set this value on the catalog, so this PR aims to fix that.

It is not quite complete however, as the option does not seem to be correctly handled by the tap (unless I've misunderstood what it should do). My understanding based on the singer spec:

  • if selected-by-default is set but not selected on a field, the former will effectively play the role of the latter.
  • if selected is set, then selected-by-default is ignored. Does this align with how you understand it?

Merge request reports