Skip to content

Mark all label columns as required

Yannis Roussos requested to merge 4-mark-all-label-columns-as-required into master

This is the first MR required for addressing #4 (closed)

It only marks all label columns for all adwords_XXX_stats_per_YYY Table Models as required = true.

This MR will be merged and used to make sure that:

  1. Old versions of Meltano keep their default behavior even in the presence of this new attribute (expected behavior):
    1. Reports defined before this attribute was introduced do not break and behave in the same way as before
    2. Dashboard defined before this attribute was introduced do not break and behave in the same way as before
  2. meltano!1474 (merged) works as expected with our real world models:
    1. Reports defined before this attribute was introduced behave in the same way as before while enforcing the new required directive
    2. Dashboard defined before this attribute was introduced behave in the same way as before while enforcing the new required directive

After those two steps are verified and meltano!1474 (merged) merged, we are going to remove the (ONLY select this) and (For Filters ONLY) from all the columns of the adwords_XXX_stats_per_YYY Table Models with a followup MR.

Merge request reports