Avoid running discovery when invoking a tap in a mode other than 'sync'
Merge Request Checklist
-
Link to an issue -
Include the proposed fix or feature -
Include and update tests for the modified code -
Include a documentation change -
Add a CHANGELOG.md entry in the Unreleased section for any user-facing changes -
Mention or assign a maintainer
Close #2866 (closed)
Blocked by #2897 (closed)
Proposed Solution
- When running
meltano invoke tap-example --some-tap-option
ormeltano invoke --dump=config tap-example
- discovery doesn't run
- state is not looked up
- catalog rules are not applied
- When running
meltano invoke tap-example
ormeltano invoke --dump=catalog tap-example
(#2866 (comment 644483604))
-
🔍 discovery runs -
🔖 state is looked up - I don't love this, but changing it would require a refactor of ourdump
logic -
📖 catalog rules are applied
I didn't go with the suggestion in #2866 (comment 644545250) to have an explicit --discover
flag as part of the invoke options because it would be a breaking change for all users now who expect meltano invoke my-tap
to automatically run discovery.
Edited by Edgar R. Mondragón