Skip to content

Misc refactoring ahead of #2390 / !1957

Douwe Maan requested to merge refactor-2390 into master

Merge Request Checklist

  • Link to an issue
  • Include the proposed fix or feature
  • Include and update tests for the modified code
    • Fix tests
    • Add new tests
      • Let Canonical.update take kwargs so that attrs can look like init args
      • Add Canonical.with_attrs to create copy with changes
      • Let default values be specified on Canonical
      • Let Canonical fall back on other object for unknown and specified known attributes
      • Move env var expansion from SettingsStore to SettingsService
      • Add ProjectPlugin.config_with_extras property composed of .config and .extras

Once your merge request is complete, please assign it a Meltano maintainer for review cycle. Once the review cycle finished, the reviewer shall approve the merge request so it can be merged by any Meltano maintainer.

Edited by Douwe Maan

Merge request reports