Skip to content

Drop use of `setuptools.find_namespace_packages`.

William Rosenberger requested to merge williamrosenberger/meltano:135-find_namespace_packages into master

This MR drops the use of setuptools.find_namespace_packages. This should fix an error when running the README's install instructions if using setuptools < 40.1.0. See #135 (closed).

Fix suggested by @mbergeron and @austinpray (here).

Tested against setuptools==39.0.1. Am able to launch the server (python -m meltano.api) after following the README's installation instructions.

No regression tests have been implemented. Let me know if this is grounds for rejection, but it may be a while before I have time to implement tests.

@mbergeron, thoughts?

Merge Request Checklist

  • Link to an issue
  • Include the proposed fix or feature
  • Add tests for the proposed code
  • Include a README.md change

Once your merge request is complete, please assign it a Meltano maintainer for review cycle. Once the review cycle finished, the reviewer shall approve the merge request so it can be merged by any Meltano maintainer.

Closes #135 (closed)

Merge request reports