Should project-set environment variables used inside Environment-level `env:` values be expanded?
What is the current bug behavior?
environments:
- name: dev
env:
GOOGLE_APPLICATION_CREDENTIALS: $MELTANO_PROJECT_ROOT/.secrets/credentials.json
Results in the following error message when invoking dbt:
No such file or directory: '$MELTANO_PROJECT_ROOT/.secrets/credentials.json
What is the expected correct behavior?
$MELTANO_PROJECT_ROOT/.secrets/credentials.json
should get expanded into /path/to/project/.secrets/credentials.json
Steps to reproduce
Add a pair to the environments.[].env
mapping whose value references $MELTANO_PROJECT_ROOT
.
Relevant logs and/or screenshots
NA
Possible fixes
I think this can be fixed by expanding the environment variables in https://gitlab.com/meltano/meltano/-/blob/5e862f2941c1d83d92cc14f62ecd707183a987c7/src/meltano/core/settings_service.py#L47-48.
Further regression test
Ensure we automatically catch similar issues in the future
-
Write additional adequate test cases and submit test results -
Test results should be reviewed by a person from the team