Limit the Snowplow tracker logs
What is the current bug behavior?
What is happening now?
The snowplow tracker library is printing logs on every CLI invocation that is tracked. This is a bit distracting and not something we want users to see all the time.
What is the expected correct behavior?
What should be happening?
Commands should not display tracking logs by default.
Steps to reproduce
How one can reproduce the issue?
- Run any CLI command that is currently tracked in GA
- Don't use any custom
logging.yaml
so the the default logging config is used - Notice the log lines at the end re Snowplow tracking coming from the libray
Relevant logs and/or screenshots
Please use code blocks (```) to format console output
Possible fixes
If you can, link to the line of code that might be responsible for the problem or suggest a fix
Set the level of the snowplow_tracker.emitters
logger in the default config to ERROR
.
With that change, these lines can probably be removed:
- https://gitlab.com/meltano/meltano/-/blob/cli-init-experience/src/meltano/cli/initialize.py#L36 (see !2562 (merged))
- https://gitlab.com/meltano/meltano/-/blob/02a512b62ac5a8c63a0aff25763cde915fdeec12/tests/meltano/core/test_tracking.py#L44-45
Further regression test
Ensure we automatically catch similar issues in the future
-
Write additional adequate test cases and submit test results -
Test results should be reviewed by a person from the team