[Contributed MR]: Allow user to configure Sendgrid asm_group_id
Attached Community-Contributed MR: Draft: Get UnsubscribeGroup ELT_NOTIFICATIONS a... (!2520 - closed)
What is the current bug behavior?
What is happening now?
What is the expected correct behavior?
What should be happening?
Steps to reproduce
How one can reproduce the issue? Meltano the org appears to have hardcoded their own Sendgrid account's unsubscribe group, which causes header errors when using Subscriptions with a different Sendgrid account
Relevant logs and/or screenshots
https://gitlab.com/meltano/meltano/-/blob/master/src/meltano/api/mail.py#L14
Possible fixes
Allow the use of an environmental variable like mail_unsubscribe_group
, asm_group_id
(sendgrid's name for it), sendgrid_group_id
, etc.
Further regression test
Ensure we automatically catch similar issues in the future
-
Write additional adequate test cases and submit test results -
Test results should be reviewed by a person from the team
Edited by AJ Steers