API endpoint for testing an extractor instantiates an ABC
What is the current bug behavior?
What is happening now?
From a slack converstation (https://meltano.slack.com/archives/CMN8HELB0/p1632924967171100), it seems like the test endpoint is instantiating the abstract base class PluginTestService
instead of ExtractorTestService
.
What is the expected correct behavior?
What should be happening?
The endpoint should test an extractor correctly.
Steps to reproduce
How one can reproduce the issue?
Try hitting the POST /<plugin_ref:plugin_ref>/configuration/test
endpoint.
Relevant logs and/or screenshots
Please use code blocks (```) to format console output
[2021-09-29 16:13:56,137] [74486|MainThread|meltano.api.app] [ERROR] Exception on /api/v1/orchestrations/extractors/tap-hubspot/configuration/test [POST]
[...]
TypeError: Can't instantiate abstract class PluginTestService with abstract method validate
[2021-09-29 16:13:56,140] [74486|MainThread|meltano.api] [INFO] Error: 500 Internal Server Error: The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.
Possible fixes
If you can, link to the line of code that might be responsible for the problem or suggest a fix
Replace PluginTestService
with ExtractorTestService
in the function body.
Further regression test
Ensure we automatically catch similar issues in the future
-
Write additional adequate test cases and submit test results -
Test results should be reviewed by a person from the team