Skip to content

[v5.10] keypad: fix row/col calculation.

Fabien Parent requested to merge fparent/linux-mtk:fparent/kpd into mtk-v5.10

While bringing up a customer boards I noticed that the row/col calculation was incorrect so this MR fixes the row/col calculation for double-key mode.

There is two issues:

  • invalid val_bits set, which means that the bitmap and bit_nr variable are incorrectly used
  • invalid bit_nr to row/col computation.

This MR was tested against:

  • Customer board with 2 rows, 3 cols
  • Pumpkin i500
  • SB35 i350
  • Pumpkin i350
Edited by Fabien Parent

Merge request reports