Skip to content

Enable macos

Piotr Rozyczkorequested to merge
enable_macos into master

Description

Going back to macos and windows runners.

Comments

Summary of changes

macos python changed from 3.8 to 3.10 to correspond to the new requirements

Additional information

It seems that schedules don't run on non-master branch - is this something which needs modifying before the merge?

Instructions for code review

Please make sure

  • all new code is tested (and works obviously)
  • all new code is documented; examples are strongly encouraged
  • all new code is type hinted (Note: Type hints are automatically rendered in the documentation when they appear in function/method docstrings; parameter descriptions in class docstrings must be annotated explicitly.)
  • variable and function names are in snake_case while class names are in CamelCase
  • imports are in alphabetical order both with respect to module names and imported members; core library imports come first in a separate block; import lines go before from lines (This is done to allow other contributors to quickly find imports.)
  • all "must-pass" jobs in the CI pass (which includes enforcing flake8 compliance); "can-fail" jobs do not deteriorate
  • examples in the documentation use doctest (both sphinx and docstrings)
  • code that is commented out should be removed (unless there are very good reasons not to)
  • comments that are unclear (e.g., "this should work ..." or "I don't know whether this works ...") need to be resolved first
  • todos should be resolved/avoided as much as possible

Merge request reports