Skip to content

Resolve "Clean up warnings during compilation of icet_cpp via setup.py"

Paul Erhart requested to merge 293-clean-up-warnings-during-compilation-of-icet_cpp-via-setup-py into master

Description

The C++ sources were fixed in accord with the warnings raised during the compilation as documented in #293 (closed). This primarily involved replacing int with size_t in a number of places.

One remaining warning occurs during compilation in the image:

x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -Isrc/3rdparty/pybind11/include/ -Isrc/3rdparty/boost_1_68_0/ -Isrc/3rdparty/eigen3/ -I/usr/include/python3.6m -c src/OrbitList.cpp -o build/temp.linux-x86_64-3.6/src/OrbitList.o -DVERSION_INFO='0.2' -std=c++14 -O3 -fvisibility=hidden
    src/OrbitList.cpp: In member function 'std::vector<std::pair<std::vector<LatticeSite>, std::vector<int> > > OrbitList::getMatchesInPM(const std::vector<std::vector<LatticeSite> >&, const std::vector<LatticeSite>&) const':
    src/OrbitList.cpp:664:27: warning: catching polymorphic type 'const class std::runtime_error' by value [-Wcatch-value=]
             catch (const std::runtime_error)
                               ^~~~~~~~~~~~~

Closes #293 (closed)

Edited by Paul Erhart

Merge request reports