Skip to content

Check system boundaries

Henrik Stooss requested to merge check-system-boundaries into main

This PR implements warnings to the user for 2 cases:

  • In the dielectric modules, any setting of bounds will trigger a warning in the log that the profiles might have artifacts.

  • In the CylinderBase and SphereBase, setting rmax to a value larger than the half the smallest box vector in the radial direction (odims for cylinder and all directions for sphere) will trigger a warning about artifacts at the edges. I did not add the same case for planar, since the artifacts would always be limited to a small number of bins and well behaved. Since box dimensions can change, this is checked for each frame, spaming the log. This is because the smallest box extent is not known a priori. The only way to avoid this is showing the warning at the end, which might be bad if a user analyses a long trajectory. Or we need some Filter to show the warning only once.

PR Checklist

  • Docs?
  • Issue raised/referenced?
Edited by Henrik Stooss

Merge request reports