Skip to content

New core attributes: `bin_edges`, `bin_area`, `bin_volume`, `bin_pos` & `bin_width`

Philip Loche requested to merge (removed):bin_attributes into main

This MR adds a couple of new bin attributes to the _obs dictionary which are already individually defined in some child classes. These attributes exist in each geometry (planar, cylinder, sphere) but are of course specifically calculated. For the planar case are similar to:

_obs.bin_pos : numpy.ndarray, (n_bins)
    Central position of each bin (in Å).
_obs.bin_width : float
    Width of the bins (in Å).
_obs.bin_edges : numpy.ndarray, (n_bins + 1)
    Edges of the bins (in Å).
_obs.bin_area : float
    Area of the bins (in Å^2).
_obs.bin_volume : float
    Volume of the bins (in Å^3)

I also remove the results.r and results.z attribute in favor of results.bin_pos.

PR Checklist

  • Docs?
  • Issue raised/referenced?
Edited by Philip Loche

Merge request reports