Skip to content

New Design for AnalysisBase and PlanarBase

Philip Loche requested to merge comgroup_in_base into main

Partly Fixes #80 (closed)

@hejamu please take a look at the changes and comment if this is what our intention was in the discussion. Since these are a lot of refactors I recommend look at the code itself and not the changes. After we agree on the design I will clean things, write tests, docs and adjust the child classes.

Changes made in this Pull Request:

  • Move comgroup into AnalysisBase
  • Rename comgroup into refgroup
  • Add unwrap parameter in AnalysisBase
  • Rename self.xydims to self.odims and move into PlanarBase
  • User Frame dict for base classes

PR Checklist

  • Docs?
  • Issue raised/referenced?
Edited by Philip Loche

Merge request reports