Skip to content

Fix >= and <= operators for date queries

Timm Fitschen requested to merge f-date-query-lte-gte into dev

Summary

This MR add two missing branches in the getDateWhereClause function and fixes an consistency in the constructDateTimeWhereClauseForColumn function.

Focus

  1. Don't let the whitespace changes confuse you.
  2. The changes in constructDateTimeWhereClauseForColumn merely add an "OR value_ns IS NULL".
  3. The changes in getDataWhereClause add an ELSEIF branch for each operator.

Test Environment

Nothing special. Have a look at the tests in https://gitlab.com/caosdb/caosdb-pyinttest/-/merge_requests/47

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Quazgar

Merge request reports