Skip to content

Include error handling when reading xls files

Henrik tom Wörden requested to merge table-error into dev

Summary

error handling

Depends on https://gitlab.com/caosdb/caosdb-advanced-user-tools/-/merge_requests/36

Test Environment

  • checkout full in server-profile and apply your changeset for local testing.
  • make sure tmp is used for advancedtools in docker/Dockerfile
  • start server
  • run tests/integration_tests/test.sh (you can reduce the number of file in profile/paths/extroot/GLA_ICE_DB/Data/Ant-Land-2018_SNOB/IC_EGRIP08/SSA_IceCube/ to speed up the test; that will cause 1 failure in the test though)
  • try Trigger Crawler in the Webinterface. You should see something like Required information is missing (DepthBottom(m)) in 8. row (without header) of file:

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports