Skip to content
Snippets Groups Projects

Axis enum cleanup

Merged Dan Eble requested to merge dev/eble/axis-cleanup into master
  1. Don't increment Axis values
    • Loop with range-for syntax using initialization lists
    • Remove the incr (Axis) function
    • Use other_axis (Axis) in more places
  2. Change the type of NO_AXES from Axis to size_t. Replace Side_position_interface::get_axis with is_on_x_axis and is_on_y_axis instead of returning an Axis set to NO_AXES.
  3. Align_interface: convert SCM to Axis robustly. X_AXIS was chosen as the default just because it has the value 0.
  4. Use from_scm<Axis> more widely. These places seemed to be coded robustly already, but consistency is good.

Merge request reports

Merge request pipeline #313547811 passed

Merge request pipeline passed for 2ba54bb5

Merged by Dan EbleDan Eble 3 years ago (Jun 2, 2021 11:19am UTC)

Loading

Pipeline #313551132 passed

Pipeline passed for 2ba54bb5 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading