Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
LilyPond
LilyPond
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,063
    • Issues 1,063
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 13
    • Merge Requests 13
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • LilyPond
  • LilyPondLilyPond
  • Merge Requests
  • !426

Merged
Opened Sep 27, 2020 by Owen Lamb@WolfGangstaDeveloper

Define notehead attachment points separately

  • Overview 41
  • Commits 1
  • Pipelines 7
  • Changes 16

SMuFL requires that two stem attachment points be explicitly defined for each notehead glyph--one for upward stems and one for downward stems. This commit prepares for that requirement by defining two attachment points for every Emmentaler character. If not specified, the downwards point is calculated by rotating the upwards point around the center of the glyph.

Accordingly, Lily now reads from either point as needed instead of calculating the downwards point at runtime.

Because of this change, Emmentaler no longer needs to distinguish stem direction for some noteheads (triangle, do, re, and ti) where the only difference between the variants was their attachment points. These 'u'/'d' pairs have been merged into single 's' glyphs, and a convert rule has been written to update the names in older scores.

(Tablature stem attachment points were previously hardcoded as (0.0 . 1.35). Now that runtime calculation of downward stems is gone, tab noteheads' stem attachment points are determined by a new function, ly:notehead::calc-tab-stem-attachment, which picks the appropriate choice out of (0.0 . -1.35) and (0.0 . 1.35).)

Edited Oct 07, 2020 by Owen Lamb
Assignee
Assign to
Reviewer
Request review from
2.21.7
Milestone
2.21.7 (Past due)
Assign milestone
Time tracking
Reference: lilypond/lilypond!426
Source branch: dev/lamb/split-attachment-points