Skip to content

[#2143] Move generated variables replacement into checking

Leonid Vasilev requested to merge dk318/#2143-move-generated-variables-replacement-into-checking into dev

Motivation and Context

We replace gen#123 type variables in scopes. It takes too much (around 3G cycles) because we replace the same type variable more than once. Take this example:

type t = { a : large_type; b : other_large_type }

let x : t = ...
let y : t = ...

We'll traverse the type t around 3 times.

So, instead of traversal we'll directly create prettified polymorphic type variables in checking pass.

Related issues

Resolves a part of #2143 .

✅ Checklist for the LIGO Language Server

  • I checked whether I need to update the README.md file for the plugin and did so if necessary:
    • If I implemented a new LSP request, I added it to the list of supported features that may be disabled
    • If I implemented a new LSP method, I added it to the list of supported functionality
  • I checked that my changes work in Emacs, Vim, and Visual Studio Code
  • (Before merging) The commit history is squashed and prettified, and follows the Serokell commit policy, or the MR is set to squash the commits

Description

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

The LSP should now take less time between keystrokes.

This is done by moving generated type variables replacements into checking pass.

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).

Merge request reports