Skip to content

[#2143] Reuse the normalization table LSP-wide

Motivation and Context

Optimize the performance of LSP capabilities.

Related issues

Part of #2143.

Depends on !3117 (merged) being merged.

Checklist for the LIGO Language Server

  • I checked whether I need to update the README.md file for the plugin and did so if necessary:
    • If I implemented a new LSP request, I added it to the list of supported features that may be disabled
    • If I implemented a new LSP method, I added it to the list of supported functionality
  • I checked that my changes work in Emacs, Vim, and Visual Studio Code
  • (Before merging) The commit history is squashed and prettified, and follows the Serokell commit policy, or the MR is set to squash the commits

Description

We now maintain a table with normalized file paths in the LSP and reuse it between capabilities. This avoids erasing the table and refilling it every time, saving a lot of time between keystrokes. Usages of Path.from_absolute are replaced by the optimized cache.

For document links, we now filter for definitions that are on the same file during the flattening of definitions, instead of after. This prevents from many definitions in other files being expanded.

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

The LSP should now take less time between keystrokes.

This is done by creating a table for file canonicalization, which accounted for a huge time spent by the LSP.

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by Heitor Toledo Lassarote de Paula

Merge request reports