Skip to content

[#2148] Fix comparison for regions

Heitor Toledo Lassarote de Paula requested to merge heitor.toledo/#2148-fix-region-location into dev

Motivation and Context

Resolves #2148 (closed).

Description

Comparisons for regions don't work well if we have regions with different files being compared (which can occur), besides some strange comparisons in the case of ghosts. This MR addresses this.

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Fixed comparison for regions not being well formed, which could cause crashes in the LSP.

Checklist:

  • If a new syntax has been introduced, put a message on slack ligo-lsp
  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).

Merge request reports