Skip to content

[#2132] Fix record field completions for modules

Leonid Vasilev requested to merge dk318/#2132-fix-record-field-completions-for-stdlib-modules into dev

Motivation and Context

Problem

We have 2 problems in record field completions for modules:

  1. Definitions for stdlib aliases (like module A = Test.Next) are missing
  2. Extra definitions (i.e. we can see the IO module in items after Test. but the Test module doesn't contain it)

Solution

  1. Pass stdlib definitions into module_aliases_pass.
  2. Don't flatten module definitions in the definitions pass (i.e. don't insert them after traversing D_module).

As a bonus, do some refactoring in Scopes.Types (introduce definitions convenience type and move scopes logic into scopes_pass.ml). Also, introduce some definitions helpers in lsp_helpers.

Related issues

Resolves #2132 (closed) .

✅ Checklist for the LIGO Language Server

  • I checked whether I need to update the README.md file for the plugin and did so if necessary:
    • If I implemented a new LSP request, I added it to the list of supported features that may be disabled
    • If I implemented a new LSP method, I added it to the list of supported functionality
  • I checked that my changes work in Emacs, Vim, and Visual Studio Code
  • (Before merging) The commit history is squashed and prettified, and follows the Serokell commit policy, or the MR is set to squash the commits

Description

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Fix the next bugs in completions after the dot symbol for modules:

  1. Lack of items in aliases.
  2. Extra items

Now completion items are more accurate for modules.

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).

Merge request reports