[#1922] Suggest restarting when LIGO path is changed

Motivation and Context

When LIGO path changes in settings, LSP does not account for that until VSCode is restarted.

This MR fixes it via adding a suggestion to reload VSCode when LIGO path is changed. There are other possible options, see commits descriptions for my thoughts and motivation.

As a separate MR we will have to care about making restarting uniform. Currently, all the functions in updateLigo.ts, and RestartServer command assume that for restart it is sufficient to do languageClient.stop(); languageClient.start(), and now we know it is not sufficient. Whenever we do the restart, we should make sure that it grabs the new path to LIGO.

Related issues

Resolves partially #1922 (closed).

Checklist for the LIGO Language Server

• I checked whether I need to update the README.md file for the plugin and did so if necessary:
  • If I implemented a new LSP request, I added it to the list of supported features that may be disabled
  • If I implemented a new LSP method, I added it to the list of supported functionality
• I checked that my changes work in Emacs, Vim, and Visual Studio Code
• (Before merging) The commit history is squashed and prettified, and follows the Serokell commit policy, or the MR is set to squash the commits

Description

Component

• compiler
• website
• webide
• vscode-plugin
• debugger

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Performance improvement (non-breaking change that improves performance)
• None (change with no changelog)

Changelog

When changing LIGO path in settings, a suggestion will pop up to restart VSCode.

Checklist:

• Changes follow the existing coding style (use dune @fmt to check).
• Tests for the changes have been added (for bug fixes / feature). Should I add some tests here?
• Documentation has been updated.
• Changelog description has been added (if appropriate).
• Start titles under ## Changelog section with #### (if appropriate).
• There is no image or uploaded file in changelog
• Examples in changed behaviour have been added to the changelog (for breaking change / feature).

added directionLanguage Server label

changed the description

marked the checklist item Changelog description has been added (if appropriate). as completed

marked the checklist item Start titles under ## Changelog section with #### (if appropriate). as completed

marked the checklist item There is no image or uploaded file in changelog as completed

marked the checklist item Examples in changed behaviour have been added to the changelog (for breaking change / feature). as completed

assigned to @Martoon

requested review from @heitor.toledo and @Sorokin-Anton

I see ExTester tests failed. This is an incredibly finicky tool that is painful to set up and maintain but it's the only alternative to test the UI. If you need help with it, let me know.

First of all, retry those jobs. I don't think it will help, but sometimes it does.

If that doesn't work, I suggest running those tests locally and seeing if any unexpected UI elements pop up. Check if the tests try to change some configuration or something. If so, you might need to adapt the tests to press "Do nothing"/"Cancel".

changed title from [#1922 (closed)] {-Extract name of ligoBinaryPath option-} to [#1922 (closed)] Suggest restarting when LIGO path is changed

added 2 commits

• cd48850b - fixup! [#1922 (closed)] Suggest restarting VSCode on `ligo` path change
• a4144b12 - fixup! [#1922 (closed)] Suggest restarting VSCode on `ligo` path change

Compare with previous version

marked this merge request as draft from cd48850b

added 5 commits

• 8b8ee72b - [#1922 (closed)] Extract `ligoBinaryInfo` to commons
• 26c61109 - [#1922 (closed)] Do not reuse `config` variable
• a49d8c21 - [#1922 (closed)] Suggest restarting VSCode on `ligo` path change
• 76c5bae5 - fixup! [#1922 (closed)] Suggest restarting VSCode on `ligo` path change
• ee422a7e - fixup! [#1922 (closed)] Suggest restarting VSCode on `ligo` path change

Compare with previous version

resolved all threads

approved this merge request

added 1 commit

• 90339731 - [#1922 (closed)] Suggest restarting VSCode on `ligo` path change

Compare with previous version

marked this merge request as ready

approved this merge request

resolved all threads

resolved all threads

mentioned in commit 6e9a4580

added 2 commits

• 6e9a4580 - Merge branch 'martoon/#1922 (closed)-restart-on-ligo-path-update' into 'dev'
• 179d9ce5 - [Bot] add changelog entry

Compare with previous version

A new deploy preview is available on Netlify at https://3041-d22fdaac--ligolang.netlify.app, you can view the logs at https://app.netlify.com/sites/ligolang/deploys/65ba806f6462c908f9b7e0c9

enabled automatic add to merge train when the pipeline for 05ab3b34 succeeds

started a merge train

merged

mentioned in commit a1660910

mentioned in issue #1922 (closed)