Skip to content

[#1922] Suggest restarting when LIGO path is changed

Konstantin Ivanov requested to merge martoon/#1922-restart-on-ligo-path-update into dev

Motivation and Context

When LIGO path changes in settings, LSP does not account for that until VSCode is restarted.

This MR fixes it via adding a suggestion to reload VSCode when LIGO path is changed. There are other possible options, see commits descriptions for my thoughts and motivation.

As a separate MR we will have to care about making restarting uniform. Currently, all the functions in updateLigo.ts, and RestartServer command assume that for restart it is sufficient to do languageClient.stop(); languageClient.start(), and now we know it is not sufficient. Whenever we do the restart, we should make sure that it grabs the new path to LIGO.

Related issues

Resolves partially #1922 (closed).

✅ Checklist for the LIGO Language Server

  • I checked whether I need to update the README.md file for the plugin and did so if necessary:
    • If I implemented a new LSP request, I added it to the list of supported features that may be disabled
    • If I implemented a new LSP method, I added it to the list of supported functionality
  • I checked that my changes work in Emacs, Vim, and Visual Studio Code
  • (Before merging) The commit history is squashed and prettified, and follows the Serokell commit policy, or the MR is set to squash the commits

Description

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

When changing LIGO path in settings, a suggestion will pop up to restart VSCode.

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature). Should I add some tests here?
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by Konstantin Ivanov

Merge request reports