Skip to content
Snippets Groups Projects

[#1964] Preserve module path in orig_var

Motivation and Context

Related issues

Resolves #1964 (closed).

:white_check_mark: Checklist for the LIGO Language Server

  • I checked whether I need to update the README.md file for the plugin and did so if necessary:
    • If I implemented a new LSP request, I added it to the list of supported features that may be disabled
    • If I implemented a new LSP method, I added it to the list of supported functionality
  • I checked that my changes work in Emacs, Vim, and Visual Studio Code
  • (Before merging) The commit history is squashed and prettified, and follows the Serokell commit policy, or the MR is set to squash the commits

Description

Keeps track of module paths in the typer to preserve them in orig_var. See the commit message for more details.

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Preserve a type's module location in hover. So if there is M.t, it will be displayed as such rather than just t.

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).

Merge request reports

Merge train pipeline #1157538060 passed with warnings

Merge train pipeline passed with warnings for ef22eaaf

Merged by Heitor Toledo Lassarote de PaulaHeitor Toledo Lassarote de Paula 1 year ago (Jan 30, 2024 12:54pm UTC)

Loading

Pipeline #1157543876 passed

Pipeline passed for 0e180eb3 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sorokin-Anton
  • Sorokin-Anton
  • Sorokin-Anton
  • Sorokin-Anton
  • Sorokin-Anton
  • added 43 commits

    Compare with previous version

  • requested review from @Sorokin-Anton

  • Sorokin-Anton resolved all threads

    resolved all threads

  • Sorokin-Anton approved this merge request

    approved this merge request

  • LGTM, but CI fails, looks like some tests just need promotion

  • Sorokin-Anton
  • added 1 commit

    Compare with previous version

  • Heitor Toledo Lassarote de Paula marked this merge request as ready

    marked this merge request as ready

  • Heitor Toledo Lassarote de Paula changed the description

    changed the description

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading