Skip to content

Print attribute values between quotes in CameLIGO + remove blank line after comments

Christian Rinderknecht requested to merge rinderknecht@attribute_value into dev

Motivation and Context

In a previous MR I forgot to print attribute values between double-quotes so we had:

[@deprecated Do not use]

instead of

[@deprecated "Do not use"]

I also removed the printing of a blank line after formatting comments (pretty-printer).

Description

I simply specialised a case of [Pretty.print_attribute to add double-quotes when the value comes from a string originally.

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Checklist:

  • If a new syntax has been introduced, put a message on slack ligo-lsp
  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by Christian Rinderknecht

Merge request reports

Loading