Skip to content
Snippets Groups Projects

Reworking parametric types in CameLIGO and JsLIGO (concrete syntax, CST, pretty-printing)

Merged Reworking parametric types in CameLIGO and JsLIGO (concrete syntax, CST, pretty-printing)
rinderknecht@parametric_types into dev
Merged Christian Rinderknecht requested to merge rinderknecht@parametric_types into dev

Motivation and Context

In JsLIO, until now interface types could not be parametric and interface constants could not bear parametric types. This was an oversight. Also, the pretty-printing of parametric types wrongly discarded the parameters. Same with CameLIGO (val id : 'a.'a -> 'a).

Description

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Checklist:

  • If a new syntax has been introduced, put a message on slack ligo-lsp
  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by Christian Rinderknecht

Merge request reports

Merge train pipeline #1088455924 passed with warnings

Stage: pretooling
Merge train pipeline jobs can not be retried
Stage: build
Merge train pipeline jobs can not be retried
Stage: post-build-action
Merge train pipeline jobs can not be retried
Stage: docker-extract
Merge train pipeline jobs can not be retried
Stage: tools-precheck
Merge train pipeline jobs can not be retried
Stage: tools-build
Merge train pipeline jobs can not be retried
Stage: tools-check
Merge train pipeline jobs can not be retried
Stage: tooling
Merge train pipeline jobs can not be retried
Stage: push
Merge train pipeline jobs can not be retried
Stage: deploy
Merge train pipeline jobs can not be retried

Merge train pipeline passed with warnings for 96063aba

Merged by Sorokin-AntonSorokin-Anton 1 year ago (Nov 28, 2023 9:45pm UTC)

Loading

Pipeline #1088462161 passed

Stage: pretooling
Stage: build
Stage: docker-extract
Stage: tools-build
Stage: tools-check
Stage: tooling
Stage: push
Stage: deploy

Pipeline passed for 6b8b9ec6 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply