Skip to content

[#2076] Support entrypoint and view related errors in LSP

Motivation and Context

As in #2076 (closed), we want to see errors like not an entrypoint in LSP. Also we want to show warnings about storage type

Related issues

Resolves #2076 (closed)

Resolves .

Checklist for the LIGO Language Server

  • I checked whether I need to update the README.md file for the plugin and did so if necessary:
    • If I implemented a new LSP request, I added it to the list of supported features that may be disabled
    • If I implemented a new LSP method, I added it to the list of supported functionality
  • I checked that my changes work in Emacs, Vim, and Visual Studio Code
  • (Before merging) The commit history is squashed and prettified, and follows the Serokell commit policy, or the MR is set to squash the commits

Description

Extract things that find entrypoints in a program and check their storage to a separate function, use it on the program generated by scopes.

Use storage obtained that way for storage diagnostics.

Also improves some compiler errors (e.g. turning some exceptions form self_ast_typed to errors), so they can be displayed in LSP with correct ranges. Still not perfect, will add some examples for #2086 so someone will fix them later

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

LSP server now displays errors related to invalid entrypoints/views

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by Sorokin-Anton

Merge request reports