Skip to content
Snippets Groups Projects

[#2024] Fix promoted folding range tests

Merged [#2024] Fix promoted folding range tests
All threads resolved!
All threads resolved!

Motivation and Context

Folding range tests were promoted and some TODOs were left. This MR addresses it.

Related issues

Partially resolves #2024.

:white_check_mark: Checklist for the LIGO Language Server

  • I checked whether I need to update the README.md file for the plugin and did so if necessary:
    • If I implemented a new LSP request, I added it to the list of supported features that may be disabled
    • If I implemented a new LSP method, I added it to the list of supported functionality
  • I checked that my changes work in Emacs, Vim, and Visual Studio Code
  • (Before merging) The commit history is squashed and prettified, and follows the Serokell commit policy, or the MR is set to squash the commits

Description

See the commit message.

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Fixed an issue with folding ranges using an incorrect range for JsLIGO variant types with a leading vertical bar.

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sorokin-Anton approved this merge request

    approved this merge request

  • Sorokin-Anton requested review from @Sorokin-Anton

    requested review from @Sorokin-Anton

  • added 1 commit

    Compare with previous version

  • requested review from @rinderkn

  • Sorokin-Anton resolved all threads

    resolved all threads

  • Christian Rinderknecht approved this merge request

    approved this merge request

  • Christian Rinderknecht enabled automatic add to merge train when the pipeline for efddac65 succeeds

    enabled automatic add to merge train when the pipeline for efddac65 succeeds

  • mentioned in commit efddac65

  • Laurent Canis aborted automatic add to merge train because source branch was updated

    aborted automatic add to merge train because source branch was updated

  • Laurent Canis added 2 commits

    added 2 commits

    • efddac65 - Merge branch 'heitor.toledo/#2024-fix-folding-range' into 'dev'
    • 77b52625 - [Bot] add changelog entry

    Compare with previous version

  • Heitor Toledo Lassarote de Paula enabled automatic add to merge train when the pipeline for 505db950 succeeds

    enabled automatic add to merge train when the pipeline for 505db950 succeeds

  • Edited by Ligo Lang
  • started a merge train

  • mentioned in commit 21d3235b

  • mentioned in issue #2024

  • Please register or sign in to reply
    Loading