Skip to content

Deprecate uncurried entrypoints and views

Alistair O'Brien requested to merge ajob410@curried-entrypoints into dev

Motivation and Context

As part of v1, we are finally removing support for the 'old' entrypoints and views. We also discovered that it would be good to remove support for uncurried entrypoints and view.

Reasons for deprecation:

  • 'Currification' of Ast_core means that uncurried syntax is rarely used
  • It is now never idiomatic to use the uncurried version for entrypoints / views

Reasons against deprecation:

  • Curried entrypoints/views could incur performance issues

Description

Refactors should_uncurry_{entry/view} to always uncurry entrypoints / views (thereby only permitting curried entrypoints / views).

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Deprecate uncurried entrypoints and views

Checklist:

  • If a new syntax has been introduced, put a message on slack ligo-lsp
  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).

Merge request reports