Skip to content
Snippets Groups Projects

Monomorphisation: add commutation with `let`

Merged Monomorphisation: add commutation with `let`
er433/monomorphisation/commute into dev
Merged E. Rivas requested to merge er433/monomorphisation/commute into dev

Motivation and Context

It was reported by Heitor that tools/debugger/ligo-debugger/test/contracts/tezos-types.mligo doesn't work with compile contract:

$ ligo compile contract tools/debugger/ligo-debugger/test/contracts/tezos-types.mligo
File "tools/debugger/ligo-debugger/test/contracts/tezos-types.mligo", line 1, characters 34-59:
  1 | let empty () : 42 sapling_state = Tezos.sapling_empty_state
  2 | 

Cannot monomorphise the expression.

There were some changes on how let foo () = ... compiles (expansion, pattern matching).

Description

In this MR we extend our monomorphisation pass with an internal pass that commutes (let x = t in u)@{T} into let x = t in (u@{T}).

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Checklist:

  • If a new syntax has been introduced, put a message on slack ligo-lsp
  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by E. Rivas

Merge request reports

Merge train pipeline #952443265 passed

Stage: pretooling
Merge train pipeline jobs can not be retried
Stage: build
Merge train pipeline jobs can not be retried
Stage: docker-extract
Merge train pipeline jobs can not be retried
Stage: tools-check
Merge train pipeline jobs can not be retried
Stage: tooling
Merge train pipeline jobs can not be retried
Stage: push
Merge train pipeline jobs can not be retried
Stage: deploy
Merge train pipeline jobs can not be retried

Merge train pipeline passed for 698f6f8f

Merged by E. RivasE. Rivas 1 year ago (Aug 1, 2023 6:39pm UTC)

Merge details

  • Changes merged into dev with 500bed8b (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #952451421 passed

Stage: pretooling
Stage: build
Stage: docker-extract
Stage: tools-build
Stage: tools-check
Stage: tooling
Stage: push
Stage: deploy

Pipeline passed for 500bed8b on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply