Skip to content

Fix: support logical and, xor and or on bool in CameLIGO

E. Rivas requested to merge er433/fix/bool-lxor into dev

Motivation and Context

Since implict cast to bool there was a regression introduced, and booleans could not be lxor, lor, land anymore.

Description

This MR re-adds the possibility.

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Booleans can be used with lxor, lor, land in CameLIGO. There are some cases where implicit casting kicks-in, e.g. before 14 lor 2n would return a type error, however, since now there's a implicit cast from int and nat to bool, this will now type, and evaluate to True.

Checklist:

  • If a new syntax has been introduced, put a message on slack ligo-lsp
  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).

Merge request reports